Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend documentation for integration tests #337

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

rolandkakonyi
Copy link
Contributor

Description

There is not much documentation about player testing in the repo right now.

Changes

  • Updated integration_test/README.md
  • Updated CONTRIBUTING.md with instructions for adding new tests
  • Added API documentation for player testing functions.

Checklist

  • 🗒 CHANGELOG entry

@rolandkakonyi rolandkakonyi self-assigned this Nov 28, 2023
@rolandkakonyi rolandkakonyi marked this pull request as ready for review November 28, 2023 15:12
export const callPlayer = async <T>(
fn: (player: Player) => Promise<T>
): Promise<T> => {
return await PlayerWorld.shared.callPlayer(fn);
};

/**
* Calls the given function with the player instance and expects the given event to occur.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? which given function

Listens for the specified Event to be emitted and waits until the event is received

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie, fixed in a416968

integration_test/playertesting/PlayerTesting.ts Outdated Show resolved Hide resolved
integration_test/playertesting/PlayerTesting.ts Outdated Show resolved Hide resolved
integration_test/playertesting/PlayerTesting.ts Outdated Show resolved Hide resolved
Base automatically changed from player-testing/add-player-testing-framework to development December 13, 2023 07:39
@rolandkakonyi rolandkakonyi merged commit 812abf9 into development Dec 13, 2023
9 checks passed
@rolandkakonyi rolandkakonyi deleted the player-testing/add-more-documentation branch December 13, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants